Update for consistency with Gala by The9Cat · Pull Request #219 · EXP-code/EXP

The9Cat · 2026-05-14T21:14:17Z

Feature update

The getAccel and getFields API now evaluate in the coordinate origin specified by the coefficients. Previous behavior required the user to supply the desired center. This is needed for Gala, but users now of the option of choosing the expansion center as origin (default) or the coefficient-specified center in getFields().

This fixes a bug in the sense that the original interface used by Gala was not implemented as intended.

Details

getAccel() has the same call signature in the API but now uses the center metadata fields in the registered coefficient instance so that the coordinates are simulation coordinates.
getFields() retains the original behavior. If one needs the same centering behavior as getAccel(), I have added a new member function that uses the coordinate origin: getFieldsOrigin().

Warnings

While not formally an API-breaking change, any workflows that used getAccel() and assumed expansion origin will find that they now are using the original simulation origin. For this reason, I am basing this PR on devel.

The Gala calls to getFields() in exp_fields.cc will need to be updated to getFieldsOrigin().

Additional minor fix

Updated the public header target to include CUDA-specific files.

ToDo

Verify compilation
Check that this fixes the issue identified by @hfoote
Run other workflow regression tests

…ilation

…ields. Origin for getFields can be (0, 0, 0) with an optional toggle.

Copilot

Pull request overview

Updates the EXP basis evaluation APIs to be consistent with Gala by making getAccel() / getFields() evaluate in the coefficient-defined coordinate origin (with an opt-out for getFields(..., origin=true)), and adjusts header installation/including for CUDA-related headers.

Changes:

Add an origin boolean to Basis::getFields / getFieldsCoefs and plumb it through the pybind layer.
Shift computeAccel implementations to use the coefficient center (coefctr) so getAccel() operates in simulation coordinates.
Install CUDA .cuH headers publicly and update internal includes to use quoted form ("...").

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
`pyEXP/BasisWrappers.cc`	Updates Python bindings/signatures and docstrings for the new `origin` behavior.
`include/SLGridMP2.H`	Switch CUDA header includes to quoted form for installed-header resolution.
`include/EmpCylSL.H`	Same include-path adjustment for CUDA headers.
`include/cudaParticle.cuH`	Adjust include style to quoted form to work from installed include directories.
`include/cudaMappingConstants.cuH`	Same include-path adjustment for CUDA headers.
`include/BiorthCyl.H`	Consolidate/add CUDA includes under `HAVE_LIBCUDA==1` with quoted includes.
`include/BiorthCube.H`	Same CUDA include consolidation as `BiorthCyl.H`.
`expui/CMakeLists.txt`	Adds CUDA `.cuH` headers to the public installed header set.
`expui/BiorthBasis.cc`	Applies coefficient-center shifting inside `computeAccel`; updates an internal `getFields` call to use `origin=true`.
`expui/BasisFactory.H`	Extends the public `Basis` API with `origin` parameter (virtual signature change).
`expui/BasisFactory.cc`	Implements centering logic for `getFields` / `getFieldsCoefs`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/5f75bca1-eb95-4f51-8ab6-9272eb114eca Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

Copilot · 2026-05-14T21:42:42Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

dl.google.com
- Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/56a9b4d8-bfcc-4bf8-9b5d-ccaa48888105 Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

…getFieldsCoefs Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/48c9ee4b-35ac-4a63-b3cb-8ecac31ecc71 Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 12 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/588ca0c8-f717-4041-8cf3-86e2c5314792 Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

Copilot · 2026-05-15T12:33:23Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

dl.google.com
- Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/5de301ef-07d4-4d2c-8595-cf3fe1b35194 Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/fe07195b-408a-42d0-b748-e96ed78bf175 Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

The9Cat

Looks fine to me. I will test it quickly.

Martin D. Weinberg added 3 commits May 14, 2026 16:13

Update list of publically installed headers necessary for a Cuda comp…

6672129

…ilation

Implement coefficient defined origin by default for getAccel and getF…

8760ca1

…ields. Origin for getFields can be (0, 0, 0) with an optional toggle.

Comment out downstream change for now

36bccc8

The9Cat requested a review from Copilot May 14, 2026 21:14

Copilot started reviewing on behalf of The9Cat May 14, 2026 21:14 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

The9Cat and others added 4 commits May 14, 2026 17:22

Potential fix for pull request finding

c412482

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

28885f4

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

84318e7

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

41f1baa

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of The9Cat May 14, 2026 21:23 View session

fix pyexp getAccel docstring typo

f41e050

Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/5f75bca1-eb95-4f51-8ab6-9272eb114eca Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

Copilot started work on behalf of The9Cat May 14, 2026 21:42 View session

Copilot finished work on behalf of The9Cat May 14, 2026 21:43

Copilot AI and others added 2 commits May 14, 2026 21:44

fix remaining getAccel docstring typos

fc5a60a

Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/56a9b4d8-bfcc-4bf8-9b5d-ccaa48888105 Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

doc: add ABI-breaking change notes to getFields methods

5592209

Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/56a9b4d8-bfcc-4bf8-9b5d-ccaa48888105 Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

Copilot finished work on behalf of The9Cat May 14, 2026 21:46

Minor simplyfing updates and improved doctstrings

86337c3

The9Cat requested a review from Copilot May 14, 2026 22:58

Copilot started reviewing on behalf of The9Cat May 14, 2026 22:58 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread expui/BasisFactory.cc Outdated

Comment thread pyEXP/BasisWrappers.cc Outdated

Comment thread pyEXP/BasisWrappers.cc Outdated

Copilot started work on behalf of The9Cat May 15, 2026 02:50 View session

Martin D. Weinberg and others added 2 commits May 14, 2026 22:51

Fix time varying centering; evaluate() should use (0, 0, 0) as origin

2de3ccd

Add backward-compatible dispatch in PyBasis trampoline for getFields/…

7329f3c

…getFieldsCoefs Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/48c9ee4b-35ac-4a63-b3cb-8ecac31ecc71 Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

Copilot stopped work on behalf of The9Cat due to an error May 15, 2026 03:05
Copilot encountered an unknown Git error. If the problem persists, please contact GitHub Support. To retry, leave a comment on this pull request asking Copilot to try again.

Copilot started work on behalf of The9Cat May 15, 2026 12:01 View session

Copilot finished work on behalf of The9Cat May 15, 2026 12:02

Copilot started work on behalf of The9Cat May 15, 2026 12:08 View session

Copilot finished work on behalf of The9Cat May 15, 2026 12:11

Copilot started reviewing on behalf of The9Cat May 15, 2026 12:13 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

Copilot started work on behalf of The9Cat May 15, 2026 12:24 View session

The9Cat and others added 9 commits May 15, 2026 08:25

Potential fix for pull request finding

080818a

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

b0f7670

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

f91be48

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

be7160b

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

a368b11

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

50ebb05

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Guard Cylindrical::computeAccel against R=0 at coefficient center

d650ae1

Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/588ca0c8-f717-4041-8cf3-86e2c5314792 Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

Flip defaults to retain previous behavior in 'getFields' calls

83ee34e

Merge branch 'galaUpdate' of github.com:EXP-code/EXP into galaUpdate

7ad2ccd

Copilot finished work on behalf of The9Cat May 15, 2026 12:33

Copilot started work on behalf of The9Cat May 15, 2026 12:33 View session

Guard FlatDisk and CBDisk computeAccel against R=0 at coefficient center

161b060

Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/5de301ef-07d4-4d2c-8595-cf3fe1b35194 Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

Copilot finished work on behalf of The9Cat May 15, 2026 12:45

The9Cat added bug Something isn't working enhancement New feature or request labels May 15, 2026

The9Cat assigned michael-petersen May 15, 2026

Copilot started work on behalf of The9Cat May 15, 2026 14:03 View session

Copilot finished work on behalf of The9Cat May 15, 2026 14:06

Copilot started work on behalf of The9Cat May 15, 2026 14:24 View session

Copilot finished work on behalf of The9Cat May 15, 2026 14:25

Copilot started work on behalf of The9Cat May 15, 2026 14:36 View session

Copilot AI and others added 2 commits May 15, 2026 14:40

Refactor getFields API and add getFieldsOrigin methods

d85e94f

Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/fe07195b-408a-42d0-b748-e96ed78bf175 Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

Fix comment typo in BasisFactory dictionary notes

cb7f333

Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/fe07195b-408a-42d0-b748-e96ed78bf175 Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

The9Cat commented May 15, 2026

View reviewed changes

Copilot finished work on behalf of The9Cat May 15, 2026 14:45

The9Cat mentioned this pull request May 15, 2026

Added coefficient-origin support to exp_fields.cc adrn/gala#593

Open

Conversation

The9Cat commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Feature update

Details

Warnings

Additional minor fix

ToDo

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented May 14, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented May 15, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

The9Cat left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

The9Cat commented May 14, 2026 •

edited

Loading